[codegen] migrate stdlib/console,date to emitsymbol/emitoperand helpers#647
Merged
[codegen] migrate stdlib/console,date to emitsymbol/emitoperand helpers#647
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
cs01
added a commit
that referenced
this pull request
Apr 22, 2026
* [codegen] migrate stdlib/crypto to emitsymbol/emitoperand helpers * scope crypto migration back to emitsymbol/emitoperand only structured ir builders (emitcall/emitgep/emitbitcast/emitload/emitstore/emitcallvoid) caused stage2 array-isarray miscompile on ci. revert them to inline emit() per step 2 wave 3 intent. only emitsymbol/emitoperand wrappers remain, matching console/date pattern from pr #647. fixes #649 --------- Co-authored-by: cs01 <cs01@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
stdlib/console.tsandstdlib/date.tsused rawctx.emittemplate strings with inlinei8* ${...},double ${...},@fflush,@stderroperands and symbol sigils.After
No user-facing change. Internal refactor only. Both files now funnel symbol references through
emitSymbol(name, "@")and all typed operands throughemitOperand(value, llvmType), matching the pattern established in PR #645 (math/process).Description
Continues Step 2 of #640. Follows the pilot PR #645 pattern:
console.ts—printf/fprintf/fflushcalls,@stderrload,%__FetchResponsebody load.date.ts—gmtime_r/localtime_r/strftime/cs_arena_alloccalls,fdiv/fptosi/sitofp/faddtype operands, struct field loads.Callers that don't have native builder methods on
IGeneratorContext(alloca, sitofp, fptosi) keep their rawctx.emitform but useemitOperandfor operand typing.Verified:
npm run verify:quickgreen; fullbash scripts/self-hosting.sh(stage 0/1/2) green.